Skip to content

Commit 35462a0

Browse files
authored
Merge pull request #19367 from smoogipoo/log-diffcalc-failure
Log beatmap difficulty retrieval failures during score calculation
2 parents 3c12b35 + 678acab commit 35462a0

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

osu.Game/Scoring/ScoreManager.cs

+5
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
using JetBrains.Annotations;
1313
using osu.Framework.Bindables;
1414
using osu.Framework.Extensions;
15+
using osu.Framework.Logging;
1516
using osu.Framework.Platform;
1617
using osu.Framework.Threading;
1718
using osu.Game.Beatmaps;
@@ -172,6 +173,10 @@ public async Task<long> GetTotalScoreAsync([NotNull] ScoreInfo score, ScoringMod
172173

173174
// We can compute the max combo locally after the async beatmap difficulty computation.
174175
var difficulty = await difficultyCache.GetDifficultyAsync(score.BeatmapInfo, score.Ruleset, score.Mods, cancellationToken).ConfigureAwait(false);
176+
177+
if (difficulty == null)
178+
Logger.Log($"Couldn't get beatmap difficulty for beatmap {score.BeatmapInfo.OnlineID}");
179+
175180
return difficulty?.MaxCombo;
176181
}
177182

0 commit comments

Comments
 (0)