Merge pull request #19441 from peppy/test-working-beatmap-unfuck

Reduce calls to `LoadTrack` by implicitly running on test/dummy classes

Author: smoogipoo

osu.Game.Tests/Gameplay/TestSceneMasterGameplayClockContainer.cs

@@ -41,8 +41,6 @@ public void TestStartThenElapsedTime()
             AddStep("create container", () =>
             {
                 var working = CreateWorkingBeatmap(new OsuRuleset().RulesetInfo);
-                working.LoadTrack();
-
                 Child = gameplayClockContainer = new MasterGameplayClockContainer(working, 0);
             });
 
@@ -58,8 +56,6 @@ public void TestElapseThenReset()
             AddStep("create container", () =>
             {
                 var working = CreateWorkingBeatmap(new OsuRuleset().RulesetInfo);
-                working.LoadTrack();
-
                 Child = gameplayClockContainer = new MasterGameplayClockContainer(working, 0);
             });
 
@@ -102,8 +98,6 @@ public void TestSeekPerformsInGameplayTime(
             AddStep("create container", () =>
             {
                 working = new ClockBackedTestWorkingBeatmap(new OsuRuleset().RulesetInfo, new FramedClock(new ManualClock()), Audio);
-                working.LoadTrack();
-
                 Child = gameplayClockContainer = new MasterGameplayClockContainer(working, 0);
 
                 gameplayClockContainer.Reset(startClock: !whileStopped);

osu.Game.Tests/Gameplay/TestSceneStoryboardSamples.cs

@@ -69,7 +69,6 @@ public void TestSamplePlaybackAtZero()
             AddStep("create container", () =>
             {
                 var working = CreateWorkingBeatmap(new OsuRuleset().RulesetInfo);
-                working.LoadTrack();
 
                 Add(gameplayContainer = new MasterGameplayClockContainer(working, 0)
                 {
@@ -96,7 +95,6 @@ public void TestSampleHasLifetimeEndWithInitialClockTime()
             AddStep("create container", () =>
             {
                 var working = CreateWorkingBeatmap(new OsuRuleset().RulesetInfo);
-                working.LoadTrack();
 
                 const double start_time = 1000;
 

osu.Game.Tests/Skins/TestSceneBeatmapSkinResources.cs

@@ -32,14 +32,17 @@ private void load()
             imported?.PerformRead(s =>
             {
                 beatmap = beatmaps.GetWorkingBeatmap(s.Beatmaps[0]);
-                beatmap.LoadTrack();
             });
         }
 
         [Test]
         public void TestRetrieveOggSample() => AddAssert("sample is non-null", () => beatmap.Skin.GetSample(new SampleInfo("sample")) != null);
 
         [Test]
-        public void TestRetrieveOggTrack() => AddAssert("track is non-null", () => !(beatmap.Track is TrackVirtual));
+        public void TestRetrieveOggTrack() => AddAssert("track is non-null", () =>
+        {
+            using (var track = beatmap.LoadTrack())
+                return track is not TrackVirtual;
+        });
     }
 }

osu.Game.Tests/Visual/Gameplay/TestSceneSkipOverlay.cs

@@ -33,7 +33,6 @@ public void SetUp() => Schedule(() =>
             increment = skip_time;
 
             var working = CreateWorkingBeatmap(CreateBeatmap(new OsuRuleset().RulesetInfo));
-            working.LoadTrack();
 
             Child = gameplayClockContainer = new MasterGameplayClockContainer(working, 0)
             {

osu.Game/Beatmaps/DummyWorkingBeatmap.cs

@@ -44,6 +44,10 @@ public DummyWorkingBeatmap([NotNull] AudioManager audio, TextureStore textures)
             }, audio)
         {
             this.textures = textures;
+
+            // We are guaranteed to have a virtual track.
+            // To ease usability, ensure the track is available from point of construction.
+            LoadTrack();
         }
 
         protected override IBeatmap GetBeatmap() => new Beatmap();

osu.Game/Overlays/FirstRunSetup/ScreenUIScale.cs

@@ -161,7 +161,6 @@ protected override IReadOnlyDependencyContainer CreateChildDependencies(IReadOnl
             private void load(AudioManager audio, TextureStore textures, RulesetStore rulesets)
             {
                 Beatmap.Value = new DummyWorkingBeatmap(audio, textures);
-                Beatmap.Value.LoadTrack();
 
                 Ruleset.Value = rulesets.AvailableRulesets.First();
 

osu.Game/Tests/Beatmaps/TestWorkingBeatmap.cs

@@ -31,8 +31,6 @@ public TestWorkingBeatmap(IBeatmap beatmap, Storyboard storyboard = null, AudioM
             this.storyboard = storyboard;
         }
 
-        public override bool TrackLoaded => true;
-
         public override bool BeatmapLoaded => true;
 
         protected override IBeatmap GetBeatmap() => beatmap;

osu.Game/Tests/Visual/OsuTestScene.cs

@@ -365,6 +365,11 @@ public ClockBackedTestWorkingBeatmap(IBeatmap beatmap, Storyboard storyboard, IF
                 }
                 else
                     track = audio?.Tracks.GetVirtual(trackLength);
+
+                // We are guaranteed to have a virtual track.
+                // To ease testability, ensure the track is available from point of construction.
+                // (Usually this would be done by MusicController for us).
+                LoadTrack();
             }
 
             ~ClockBackedTestWorkingBeatmap()