Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to access beatmap files from the editor #12029

Closed
peppy opened this issue Mar 17, 2021 · 3 comments
Closed

Add the ability to access beatmap files from the editor #12029

peppy opened this issue Mar 17, 2021 · 3 comments
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game

Comments

@peppy
Copy link
Member

peppy commented Mar 17, 2021

A (relatively) common paradigm for a mapper is to perform operations on the .osu or .osb files contained within a beatmap. This can either be copy/pasting the raw code itself, or drag-dropping the files into a third party program to perform mutation or inspection.

We should give the user a way to access the raw files on demand, likely creating a temporary folder on disk, locking the game interface, and waiting for the user to perform operations, at which point they would press a button in the game and the folder would be cleaned up.

An alternative may be to always follow this paradigm on entering the editor, pulling the files out when entering (as a background operation?) to allow for ongoing edits, and using a FileSystemWatcher to handle any external changes. This implementation is obviously a higher bar in terms of complexity.

@peppy peppy added area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels Mar 17, 2021
@yyny
Copy link

yyny commented Jun 28, 2021

We don't necessarily need FileSystemWatcher for synchronization (Although that would be more snappy and less intrusive), we can simply check for file changes whenever the game client regains focus. I would recommend that as a start for anyone looking to implement this.

@frenzibyte
Copy link
Member

Whether this needs FileSystemWatcher or not probably depends on how the implementation goes, it's a small detail to even care about currently.

@Joehuu
Copy link
Member

Joehuu commented Oct 4, 2024

Implemented in #28800.

@Joehuu Joehuu closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game
Projects
None yet
Development

No branches or pull requests

4 participants