Use "Command" key rather than "Control" for global keybinds on macOS

[frenzibyte]

• Depends on Create better standards for default key bindings to avoid conflicts #12776

---

macOS users are used to using the Command key (superkey/windows key) for shortcuts normally activated with control, i suggest that osu! should check what platform its running on and switch the keys on macOS

Originally posted by @TMinusBlastedRocket in #13481

[bdach]

This is already the case to a degree, is it not? At least framework seems to define platform actions in such a way.

[frenzibyte]

Yep I've specifically mentioned "global keybinds" in the title as that's the place where this hasn't been done yet.

[peppy]

Can a list be provided here of which keys are currently an issue? I'm not sure if we should be changing all of them, so we should at least document which should be changed so someone attempting this gets it right.

[frenzibyte]

Reading on the Apple Human Interface Guidelines, it states the following in the "Defining Keyboard Shortcuts" section:

As much as possible, avoid using the Control key as a modifier. The Control key is already used extensively throughout the system. To avoid possible conflicts, use it only when necessary.

So we may actually have to replace all of them with the Command key, as the Control key should remain for system-level keybinds only. That includes all of the global keybinds using that modifier:

osu/osu.Game/Input/Bindings/GlobalActionContainer.cs

Lines 46 to 51 in 385d10e

	new KeyBinding(new[] { InputKey.Control, InputKey.Alt, InputKey.R }, GlobalAction.ResetInputSettings),
	new KeyBinding(new[] { InputKey.Control, InputKey.T }, GlobalAction.ToggleToolbar),
	new KeyBinding(new[] { InputKey.Control, InputKey.O }, GlobalAction.ToggleSettings),
	new KeyBinding(new[] { InputKey.Control, InputKey.D }, GlobalAction.ToggleBeatmapListing),
	new KeyBinding(new[] { InputKey.Control, InputKey.N }, GlobalAction.ToggleNotifications),
	new KeyBinding(new[] { InputKey.Control, InputKey.Shift, InputKey.S }, GlobalAction.ToggleSkinEditor),

osu/osu.Game/Input/Bindings/GlobalActionContainer.cs

Line 65 in 385d10e

new KeyBinding(new[] { InputKey.Control, InputKey.Shift, InputKey.R }, GlobalAction.RandomSkin),

osu/osu.Game/Input/Bindings/GlobalActionContainer.cs

Line 74 in 385d10e

new KeyBinding(new[] { InputKey.Control, InputKey.Shift, InputKey.A }, GlobalAction.EditorVerifyMode),

osu/osu.Game/Input/Bindings/GlobalActionContainer.cs

Lines 84 to 86 in 385d10e

	new KeyBinding(new[] { InputKey.Control, InputKey.Tilde }, GlobalAction.QuickExit),
	new KeyBinding(new[] { InputKey.Control, InputKey.Plus }, GlobalAction.IncreaseScrollSpeed),
	new KeyBinding(new[] { InputKey.Control, InputKey.Minus }, GlobalAction.DecreaseScrollSpeed),

osu/osu.Game/Input/Bindings/GlobalActionContainer.cs

Line 106 in 385d10e

new KeyBinding(new[] { InputKey.Control, InputKey.F4 }, GlobalAction.ToggleMute),

While it currently doesn't make much sense to change some of them, the current combinations used for the global keybinds are known to be over the place, and it may be better to mark that as a dependency for this, so nothing feels weird/incorrect when applying this guideline to the combinations.

But also while thinking about this, the key combination for switching rulesets (Control+Num) would have to change as well, to completely follow the guidelines there. Command+Num may not be right... Alt+Num? Alt+Shift+Num? not completely sure.

[peppy]

I think you're missing the point. All those global bindings are system keys. Also they are not used by macOS in any way, unless you count text manipulation (which doesn't work in a game in the first place).

Rather than blindly following a guide, I'd recommend actually understanding which bindings macOS uses the control key for. We aren't changing the ones that are not going to conflict with our application.

[peppy]

Going to close this until the user actually says which keys they are finding troubling. Kinda pointless in this state.