Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scores are sometimes displayed as 0 #19356

Closed
isuewo opened this issue Jul 24, 2022 · 4 comments
Closed

Scores are sometimes displayed as 0 #19356

isuewo opened this issue Jul 24, 2022 · 4 comments

Comments

@isuewo
Copy link

isuewo commented Jul 24, 2022

Type

Other

Bug description

This is the second time I've encountered this bug and I honestly don't know how to consistently reproduce it, but sometimes it just happens

Screenshots or videos

image

I don't know why the video is corrupted, but downloading and then opening it should work:

output.mp4

Version

2022.723.0-lazer

Logs

database.log
performance.log
network.log
runtime.log

@smoogipoo
Copy link
Contributor

I thought there was another similar issue duplicating this (not #18824).

The working theory is that difficulty calculation is being cancelled, which caches null values to the cache. Still investigating...

@smoogipoo smoogipoo removed the missing details Can't move forward without more details from the reporter label Jul 25, 2022
@smoogipoo
Copy link
Contributor

As it turns out, BeatmapDifficultyCache already doesn't cache null values (i.e. from cancelled calculations):

protected override bool CacheNullValues => false;

So back to the drawing board with this one. The above PR adds a bit of logging but I don't believe it'll be too useful here.

@peppy
Copy link
Member

peppy commented Aug 1, 2022

This will also be resolved with the direction we're taking (adding extra statistical data as per #19380 to avoid requiring beatmap difficulty calculation for score computation).

@peppy
Copy link
Member

peppy commented Aug 1, 2022

Will track via #19519.

@peppy peppy closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants