Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu!catch shows cursor on the left/right edges of the screen #21644

Closed
Mogiiii opened this issue Dec 15, 2022 · 0 comments
Closed

osu!catch shows cursor on the left/right edges of the screen #21644

Mogiiii opened this issue Dec 15, 2022 · 0 comments

Comments

@Mogiiii
Copy link
Contributor

Mogiiii commented Dec 15, 2022

Type

Cosmetic

Bug description

osu!catch now hides the cursor on the playfield ( #21625 ) but since the playfield only covers the middle ~half of the screen the cursor still shows up on the edges. Since CatchPlayField.RecievePositionalInputAt already doesn't care Y axis, we can modify it to not care about the X axis either to "solve" the issue. I.E. RecievePositionalInputAt always returns true. This type of function returning a constant feels like a hack more than a proper solution to me, so I am opening this issue to solicit feedback.

public override bool ReceivePositionalInputAt(Vector2 screenSpacePos) =>
     // only check the X position; handle all vertical space.
     base.ReceivePositionalInputAt(new Vector2(screenSpacePos.X, ScreenSpaceDrawQuad.Centre.Y));

This should have been fixed as part of #21625 but I thought this was an issue with the touchscreen controls rather than the playfield. I have since discovered otherwise.

Screenshots or videos

2022-12-15.00-28-59.mp4

Version

60c8ef3

Logs

N/A

@ppy ppy locked and limited conversation to collaborators Dec 15, 2022
@peppy peppy converted this issue into discussion #21645 Dec 15, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant