Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeatmapOptionsOverlay is missing new design #24273

Closed
Tracked by #22204
Joehuu opened this issue Jul 17, 2023 · 4 comments · Fixed by #24712
Closed
Tracked by #22204

BeatmapOptionsOverlay is missing new design #24273

Joehuu opened this issue Jul 17, 2023 · 4 comments · Fixed by #24712

Comments

@Joehuu
Copy link
Member

Joehuu commented Jul 17, 2023

Nowhere to be seen in https://www.figma.com/file/DXKwqZhD5yyb1igc3mKo1P/Song-Select-Draft-2?type=design&node-id=0-1&mode=design&t=OgFGHnbe4rJH7Vlt-0 as of now.

Tracking as it was ignored multiple times during the implementation of the new footer and it's not in the client yet mostly because of this.

Ref:

@arflyte still missing design

osu! 2022-12-01 at 06 44 46

what do

Originally posted by @peppy in #20148 (comment)

@peppy
Copy link
Member

peppy commented Jul 18, 2023

@arflyte

1 similar comment
@peppy
Copy link
Member

peppy commented Jul 25, 2023

@arflyte

@Tanza3D
Copy link

Tanza3D commented Jul 25, 2023

was asked by peppy to try a design on this;
image

there's probably some existing components and such which look a bit different than this, but this is a general idea of how i feel it should look. - uses the same dropdown ui than in editor, just with an error (arrow is not too important if it's too complex to add)

image

background in that ui is B/B4 - Card, and the buttons are B/B3 - Brighter Card, though again if existing components differ from that i feel it's fine

https://www.figma.com/file/2PxrcTbYoFXzHj4ctD9tde/Lazer-%7C-Song-Select-Options-Dropdown?type=design&node-id=0%3A1&mode=design&t=kh046WQrmfkPnQS7-1

@peppy
Copy link
Member

peppy commented Jul 26, 2023

I think this looks pretty decent 👍 .

@Joehuu Joehuu self-assigned this Sep 3, 2023
@Joehuu Joehuu moved this from Next up to In Progress in osu! development roadmap Sep 3, 2023
@Joehuu Joehuu moved this from In Progress to Done in osu! development roadmap Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants