Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty sort groups beatmaps by set, making it mostly useless #2547

Closed
jorolf opened this issue May 14, 2018 · 12 comments · Fixed by #24614
Closed

Difficulty sort groups beatmaps by set, making it mostly useless #2547

jorolf opened this issue May 14, 2018 · 12 comments · Fixed by #24614

Comments

@jorolf
Copy link
Contributor

jorolf commented May 14, 2018

The current design for beatmapsets with only one beatmap is this:
old

This is different from what stable does where it only uses one panel:
stable

perhaps the design could be adjusted to be similar to stable:
new

@peppy peppy added the design label May 15, 2018
@peppy peppy added this to the Candidate Issues milestone May 15, 2018
@peppy
Copy link
Member

peppy commented May 15, 2018

I'm not sure if this is going to happen or not, but it sure as hell isn't going to look like that.

@DudeMartin
Copy link

DudeMartin commented May 20, 2018

What about just displaying the version of the beatmap and its star rating?

singlemapsetmock

I'm considering modifying the artist text to display the mapper just like it does in stable. So in the picture above, it would say IAHN // Monstrata. This makes it so that the redesign does not omit any information.

Update: I think a dot looks better than two forward slashes to separate the song artist and mapper.

singlemapmockwithmapper

@lukis101
Copy link

Longer diff names would push star ratings further to the right thus giving visual inconsistency. (Not a designer, just my 2¢)

@peppy
Copy link
Member

peppy commented Aug 22, 2019

Moving this out of milestone. It's clear we do not have the bandwidth to implement this just yet.

@LittleEndu
Copy link
Contributor

Is there a design for this? I'm looking to rework how the carousel draws its panels so a design would be nice to have.

@peppy
Copy link
Member

peppy commented Apr 7, 2020

We haven't finalised the UX or design for this just yet. Needs further discussion, so stick with what we have for now.

@LittleEndu
Copy link
Contributor

I want to try implement carousel grouping. Can I make up a design that fits what we have right now or should we wait for the new design to be final before implementing the logic necessary for carousel grouping?

@peppy
Copy link
Member

peppy commented Sep 10, 2021

You're most welcome to try, as long as you're prepared to get shot down. I still don't have anything yet (and would need to experiment myself to give any kind of direction).

@smoogipoo
Copy link
Contributor

Groupings were added to the designs https://www.figma.com/file/DXKwqZhD5yyb1igc3mKo1P/Song-Select-Draft-2?node-id=0%3A1
@arflyte Can you confirm whether the design showing carousel groupings (as seen in the second from bottom-right) is the latest design or not? Because the panels in the top-most design are significantly different. Are there two different panel designs for grouped vs non-grouped displays?

@LittleEndu
Copy link
Contributor

Another question is what this issue originally was: Should beatmap sets with single difficulty be displayed as if they would in the non-consecutive case or should header and difficulties version be preferred when not grouping?

@halbGefressen
Copy link

To be honest, I think the behaviour should just mimic the old osu! client. E.g. sorting by difficulty should yield the separate difficulties in the exact difficulty ordering.

@peppy
Copy link
Member

peppy commented Sep 24, 2022

That is the plan. We have a design ready to go for this, and you will probably see it appear within the next few months.

@peppy peppy changed the title Decide how beatmap sets should be split apart for non-consecutive display Difficulty sort groups beatmaps by set, making it mostly useless Aug 23, 2023
@peppy peppy assigned peppy and unassigned arflyte Aug 23, 2023
@peppy peppy moved this to In Progress in Path to osu!(lazer) ranked play Aug 23, 2023
@bdach bdach moved this from In Progress to In Review in Path to osu!(lazer) ranked play Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

8 participants