-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difficulty sort groups beatmaps by set, making it mostly useless #2547
Comments
I'm not sure if this is going to happen or not, but it sure as hell isn't going to look like that. |
What about just displaying the version of the beatmap and its star rating? I'm considering modifying the artist text to display the mapper just like it does in stable. So in the picture above, it would say IAHN // Monstrata. This makes it so that the redesign does not omit any information. Update: I think a dot looks better than two forward slashes to separate the song artist and mapper. |
Longer diff names would push star ratings further to the right thus giving visual inconsistency. (Not a designer, just my 2¢) |
Moving this out of milestone. It's clear we do not have the bandwidth to implement this just yet. |
Is there a design for this? I'm looking to rework how the carousel draws its panels so a design would be nice to have. |
We haven't finalised the UX or design for this just yet. Needs further discussion, so stick with what we have for now. |
I want to try implement carousel grouping. Can I make up a design that fits what we have right now or should we wait for the new design to be final before implementing the logic necessary for carousel grouping? |
You're most welcome to try, as long as you're prepared to get shot down. I still don't have anything yet (and would need to experiment myself to give any kind of direction). |
Groupings were added to the designs https://www.figma.com/file/DXKwqZhD5yyb1igc3mKo1P/Song-Select-Draft-2?node-id=0%3A1 |
Another question is what this issue originally was: Should beatmap sets with single difficulty be displayed as if they would in the non-consecutive case or should header and difficulties version be preferred when not grouping? |
To be honest, I think the behaviour should just mimic the old osu! client. E.g. sorting by difficulty should yield the separate difficulties in the exact difficulty ordering. |
That is the plan. We have a design ready to go for this, and you will probably see it appear within the next few months. |
The current design for beatmapsets with only one beatmap is this:
This is different from what stable does where it only uses one panel:
perhaps the design could be adjusted to be similar to stable:
The text was updated successfully, but these errors were encountered: