Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break not showing in lazer #28717

Closed
KnowScratcher opened this issue Jul 3, 2024 · 3 comments · Fixed by #28771
Closed

Break not showing in lazer #28717

KnowScratcher opened this issue Jul 3, 2024 · 3 comments · Fixed by #28771
Assignees

Comments

@KnowScratcher
Copy link

Type

Game behaviour

Bug description

The game doesn't show the break countdown in lazer.
There are three breaks in this beatmap, and the first and second break show but the last doesn't.

Screenshots or videos

image

image

Version

2024.625.2

Logs

compressed-logs.zip

@frenzibyte
Copy link
Member

@KnowScratcher Please link the beatmap.

@frenzibyte frenzibyte added the missing details Can't move forward without more details from the reporter label Jul 4, 2024
@KnowScratcher
Copy link
Author

I haven't upload it yet, but here's the osz file
https://drive.google.com/file/d/1_eWI7jzjszp7ErewwOGM_-qSz31DbAM5/view?usp=sharing
The issue occurred in the last break of the "easy" difficulty

@frenzibyte frenzibyte self-assigned this Jul 8, 2024
@frenzibyte frenzibyte removed the missing details Can't move forward without more details from the reporter label Jul 8, 2024
@frenzibyte
Copy link
Member

frenzibyte commented Jul 8, 2024

Okay I can see what's going on. This can be reproduced by creating a beatmap with two auto-generated break periods, modify the duration of the second break period, then trigger the auto-generation logic again by moving the time of any object.

BreakOverlay expects break periods to be in chronological order (as it uses BeginAbsoluteSequence to populate the show/hide transforms of the break overlay), but the auto-generation logic outputs an unordered break periods as it keeps ManualBreakPeriods and adds the auto-generated break periods on top of it regardless of the interval of the manual break periods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants