Audio offset calibration doesn't take into account the offset in last play when quitting beatmap and playing it again without using "retry" button

[serobor]

Type

Game behaviour

Bug description

Audio offset calibration doesn't take in account the offset in last play when quitting beatmap and playing it again without using "retry" button.
I was hitting early on purpose, so I got +50 ms offset calibration, on next play I got -4,46 ms. If I calibrated offset without quitting, I would get 45,54ms offset. Instead I quit beatmap and started playing it again, calibrated offset, but I got -4,46 ms. The 50ms which I got before, were ignored.

Screenshots or videos

2024-07-06.22-31-40.mp4

Version

2024.625.2-lazer

Logs

compressed-logs.zip

[peppy]

If you wait a minute at song select before playing the second time does this work correctly?

[serobor]

If you wait a minute at song select before playing the second time does this work correctly?

No, waiting doesn't help. After you quit beatmap and average hit error is saved (3 ms early for example), if you play beatmap again and calibrate audio offset, it will set 3ms, ignoring previous offset. It will work correctly only if you retry a beatmap without returning to song select (retrying from a result screen works correctly too)

[shiumano]

I don't think it's a delay, I think something is wrong.

recording.mp4

[Sebaex]

From what i found is that lastPlayBeatmapOffset here goes to 0 once the player exits the song so it messes up on where to consider the auto offset, if there was another way to get the map's current offset it should fix the problem

osu/osu.Game/Screens/Play/PlayerSettings/BeatmapOffsetControl.cs

Lines 214 to 217 in c90e040

	lastPlayAverage = average;
	lastPlayBeatmapOffset = Current.Value;