Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent lag spike when entering Song Select on 2024.718.0 #28929

Closed
jvyden opened this issue Jul 18, 2024 · 6 comments · Fixed by #28946
Closed

Consistent lag spike when entering Song Select on 2024.718.0 #28929

jvyden opened this issue Jul 18, 2024 · 6 comments · Fixed by #28946
Assignees
Labels
area:song-select priority:0 Showstopper. Critical to the next release. type:performance

Comments

@jvyden
Copy link
Contributor

jvyden commented Jul 18, 2024

Type

Performance

Bug description

Definitely seems to be a regression since last release. It's possible this scales with the number of songs you have because in the Discord links I post below, there's a user with 86k maps that has a spike that lasts several seconds as opposed to the smaller stutters I show in my video, with only 12k maps.

Screenshots or videos

2024-07-18.17-18-21.mp4

I also see this being reported in Discord:

Version

2024.718.0

Logs

compressed-logs.zip

@Ladwick
Copy link

Ladwick commented Jul 18, 2024

I'm having the same issue.

@bdach
Copy link
Collaborator

bdach commented Jul 18, 2024

@jvyden since you are a person that should not be scared of an IDE, could you do me a solid and see if reverting #28890 fixes it? I have a suspicion what the cause is but it'd be probably easier for you to confirm.

@jvyden
Copy link
Contributor Author

jvyden commented Jul 18, 2024

Sure, I'll take a look right now.

@jvyden
Copy link
Contributor Author

jvyden commented Jul 18, 2024

Sorry for the delay. I have discovered that, if anything, the IDE is scared of me.

Anyways, the stutter still appears to be there after reverting the commits in those PRs.

I would do some profiling/debugging myself but my computer has decided that now is the time to fight back.

@jvyden
Copy link
Contributor Author

jvyden commented Jul 19, 2024

Ended up reformatting my entire OS just to get to the bottom of this issue... 😅

If I'm understanding correctly, it looks like the stutter is caused by a big Realm query happening on the update thread:

image

https://github.com/ppy/osu/blob/master/osu.Game/Screens/Select/BeatmapCarousel.cs#L132
this is called by a line added as part of #28769:
https://github.com/peppy/osu/blob/8f271170e94fa7fdf547b70b5f107a7679194d0c/osu.Game/Screens/Select/BeatmapCarousel.cs#L284

(Lazily) reverting the changes of #28769 fixes the stutter.

@frenzibyte
Copy link
Member

cc @peppy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:song-select priority:0 Showstopper. Critical to the next release. type:performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants