-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent lag spike when entering Song Select on 2024.718.0 #28929
Comments
I'm having the same issue. |
Sure, I'll take a look right now. |
Sorry for the delay. I have discovered that, if anything, the IDE is scared of me. Anyways, the stutter still appears to be there after reverting the commits in those PRs. I would do some profiling/debugging myself but my computer has decided that now is the time to fight back. |
Ended up reformatting my entire OS just to get to the bottom of this issue... 😅 If I'm understanding correctly, it looks like the stutter is caused by a big Realm query happening on the update thread: https://github.com/ppy/osu/blob/master/osu.Game/Screens/Select/BeatmapCarousel.cs#L132 (Lazily) reverting the changes of #28769 fixes the stutter. |
cc @peppy |
Type
Performance
Bug description
Definitely seems to be a regression since last release. It's possible this scales with the number of songs you have because in the Discord links I post below, there's a user with 86k maps that has a spike that lasts several seconds as opposed to the smaller stutters I show in my video, with only 12k maps.
Screenshots or videos
2024-07-18.17-18-21.mp4
I also see this being reported in Discord:
Version
2024.718.0
Logs
compressed-logs.zip
The text was updated successfully, but these errors were encountered: