Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility and differentiation between beat markers on timeline is not great #29024

Closed
rvneXe opened this issue Jul 23, 2024 · 3 comments
Closed
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users. type:cosmetic

Comments

@rvneXe
Copy link

rvneXe commented Jul 23, 2024

Type

Other

Bug description

Hi. Time signature is so useful when sampling hitsounds, but in lazer, they're not that recognizable.
Take a look:

image
1/4 is way longer than other beats.

image
1/4 is slightly longer, and thicker than other beats.

and I think it's still so much harder to recognize, compared to stable one.
We can make the *other beats* grey, thinner, and shorter to make it easier to recognize.

Screenshots or videos

No response

Version

2024.718.1

Logs

No need

@peppy
Copy link
Member

peppy commented Jul 23, 2024

The height difference was drastically reduced recently and I agree it's not great. But consider that you're not comparing 1/4 to 1/4, you're comparing 1/1 to 1/4 (lazer lines are all white, aka 1/1).

We may end up moving the ticks in front of objects again, although will need work on line rendering to make that look good.

@bdach
Copy link
Collaborator

bdach commented Jul 23, 2024

The height difference was drastically reduced recently

...to fix the fact that in some situations the tick could be entirely obscured.

Just to make sure this is clearly stated.

@peppy peppy changed the title Useless differentiation between beat bars Visibility and differentiation between beat markers on timeline is not great Aug 7, 2024
@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Aug 7, 2024
@peppy
Copy link
Member

peppy commented Aug 29, 2024

Should be resolved via #29545.

@peppy peppy closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users. type:cosmetic
Projects
None yet
Development

No branches or pull requests

4 participants