Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempting to set sample bank on slider with multiple banks doesn't always work #29361

Closed
peppy opened this issue Aug 9, 2024 · 0 comments · Fixed by #29533
Closed

Attempting to set sample bank on slider with multiple banks doesn't always work #29361

peppy opened this issue Aug 9, 2024 · 0 comments · Fixed by #29533
Assignees
@bdach
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@peppy
Copy link
Member

peppy commented Aug 9, 2024

If the slider head's bank matches the button you attempt to press, it doesn't seem to work (see "soft" case in video). Other buttons work fine.

osu.2024-08-09.at.06.51.18.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect bank set / sample addition logic bdach/osu
2 participants
@peppy @bdach