SkinnableSprite not working

[fuyukiSmkw]

Type

Cosmetic

Bug description

SkinnableSprite cannot show any asset although it exists.

Screenshots or videos

2024-08-16.19-08-12.mp4

Version

2024.816.0-lazer

Logs

compressed-logs.zip

[cdwcgt]

The first commit where this problem occurred was dcafee7

git reset --hard 657da34 will be fine

I haven't watched it specifically, but it should be the regress of #26249

The following changes can solve the problem

But I don't know if I should do this, because it didn't change it at the beginning, and I don't know why.

diff --git a/osu.Game/Skinning/Skin.cs b/osu.Game/Skinning/Skin.cs
index 3a83815f0e..472cfe4704 100644
--- a/osu.Game/Skinning/Skin.cs
+++ b/osu.Game/Skinning/Skin.cs
@@ -185,7 +185,15 @@ public void UpdateDrawableTarget(SkinComponentsContainer targetContainer)
             {
                 // This fallback is important for user skins which use SkinnableSprites.
                 case SkinnableSprite.SpriteComponentLookup sprite:
-                    return this.GetAnimation(sprite.LookupName, false, false, maxSize: sprite.MaxSize);
+                    var drawable = this.GetAnimation(sprite.LookupName, false, false, maxSize: sprite.MaxSize);
+                    if (drawable == null)
+                        break;
+
+                    return new UserConfiguredLayoutContainer
+                    {
+                        AutoSizeAxes = Axes.Both,
+                        Child = drawable
+                    };

                 case SkinComponentsContainerLookup containerLookup:

[iwa]

just to add a bit on that, happens on all the layers, not only on HUD layer

[bdach]

@frenzibyte @peppy FYI

[peppy]

yeah, on my radar thanks.