You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 21, 2024. It is now read-only.
Is your feature request related to a problem? Please describe.
We would like to see the tag partially-approved only when branch protection's request is not met.
Right now, the code also checks if everyone requested has approved it. The combination of CODEOWNER file and our flow, we tend to over-request for reviews, making it impossible for some PR to attain the proper approved tag.
Describe the solution you'd like
I would like to remove the second portion of this code, numRequestedReviewsRemaining > 0. If this is approved and people agree with this, I can submit PR to update this feature.
Describe alternatives you've considered
Offer it as a configuration option.
Additional context
I would also like to hear @allout58 's thoughts on this since this is their feature.
The text was updated successfully, but these errors were encountered:
That makes sense. If there is a way to make it configurable, that would be nice (still would have to pick one to be the default, but that's not too big of a deal).
My original thought was to prevent it from being "approved" if you had requested a review from someone you don't normally request. Or for odd cases like our usual flow where we have two team leads (both CODEOWNERS) and want to require both to approve a PR from our junior developers, but don't want to require 2 reviews on the whole branch so he and I can just review each other without getting others involved.
@maestromac
I have not yet been able to make time to investigate. I would appreciate it if you create a pull request to fix the issue.
Thanks in advance
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem? Please describe.
We would like to see the tag
partially-approved
only when branch protection's request is not met.Right now, the code also checks if everyone requested has approved it. The combination of CODEOWNER file and our flow, we tend to over-request for reviews, making it impossible for some PR to attain the proper
approved
tag.Describe the solution you'd like
I would like to remove the second portion of this code,
numRequestedReviewsRemaining > 0
. If this is approved and people agree with this, I can submit PR to update this feature.Describe alternatives you've considered
Offer it as a configuration option.
Additional context
I would also like to hear @allout58 's thoughts on this since this is their feature.
The text was updated successfully, but these errors were encountered: