Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for on-premise instance for edit link #35

Closed
lalmeras opened this issue Jul 18, 2022 · 3 comments
Closed

Support for on-premise instance for edit link #35

lalmeras opened this issue Jul 18, 2022 · 3 comments

Comments

@lalmeras
Copy link

Edit link only supports SaaS instance (gitlab.com, github.com, bitbucket.org). github and gitlab (I don't know for bitbucket) allow on-premise instance, with custom urls.

Can we add a source_provider optional setting, with allowed values github|gitlab|bitbucket that override edit link building behavior and allow to use edit link with on-premise instance. If source_provider is missing, we can use startswith check to automatically handle gitlab.com/github.com/bitbucket.org cases.

I step into this issue as I use furo theme, and configuring edit link feature triggers Could not understand "source_repository" provided messages, and edit link is generated with an empty href.

@lalmeras
Copy link
Author

I create #36 with a proposal.

@lalmeras
Copy link
Author

My bad, @pradyunsg pointed that #34 already addresses this feature. I just tested this PR and it allows to customize edit link as expected.

@pradyunsg
Copy link
Owner

Merged that one, I'll cut a release and enable this in Furo sometime later in the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants