Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit_sm calls should support a list of encodings #813

Open
smn opened this issue Jun 3, 2014 · 1 comment
Open

submit_sm calls should support a list of encodings #813

smn opened this issue Jun 3, 2014 · 1 comment

Comments

@smn
Copy link
Member

smn commented Jun 3, 2014

When submit_sm_encoding is set to utf-16be hello world is encoded accordingly. This means that when we have an SMS like:

'a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a '

It's delivered as:

'\x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 \x00a\x00 '

which results in ~4 SMSs because that's 70 chars per SMS.

Somewhere there should be a flag that selects a suitable encoding based on the input because this should fit in a single SMS with utf-8.

@smn
Copy link
Member Author

smn commented Jun 3, 2014

Not even sure what the configs for this need to look like.
Perhaps a dcs <-> encoding map like we have for deliver_sm and a separate big on the processor that tells us what dcs value we should use for a piece of string?

@hodgestar @jerith thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant