-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docker metadata labels in prebuilt images #91
Comments
You could also include a sha512 sum of the image as a label, version, etc.? |
I thought I had fixed this issue in c43334c, but it turns out I did not. I manually re-ran the It sounds like this is a bug or limitation in the In another project, they worked around this by manually merging the single-architecture Docker image manifests: dbschenker/vaultpal#31 Fixing this deficiency in Nosey Parker will require some more work, probably a manual merge of manifests. It may make sense anyway to manually merge single-architecture Docker images, as the overall Docker workflow could be drastically sped up that way (instead of using qemu to build the ARM64 image, we could use the new M1 macOS runner, avoiding slow binary translation). See docker/build-push-action#846 for inspiration. |
A "fast" way to build a multi arch docker image that I found easier, is simply to use the 2 different build aka x86_64 and arm64 and then just 'publish' to the same container image repo. It should 'just work'. Havent' tried this with non docker repos though! |
Be sure to use the same tag! |
The prebuilt Docker images for releases do not include all the metadata one would like. See here, for example: https://github.com/praetorian-inc/noseyparker/pkgs/container/noseyparker/137062442?tag=v0.15.0. No labels!
The text was updated successfully, but these errors were encountered: