Remove application/0 from mix.exs #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [Elixir v1.4 introduced "application inference"](https://github.com/elixir-lang/elixir/blob/v1.4/CHANGELOG.md#application-inference) we don't need to manually set :applications, as it's inferred from deps. In fact, setting :applications explicitly can be harmful because it overrides inference, so if you add another dep but forget to update this list, that application won't be part of the release. That's exactly the reason for the recent bug, setting `applications: []` was overriding inference.
|
Ty @wojtekmach so this is even a better fix for #375 then, correct? |
|
oh I cant'read you said so, thx again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Elixir v1.4 introduced "application inference" we don't need to manually set :applications, as it's inferred from deps. In fact, setting :applications explicitly can be harmful because it overrides inference, so if you add another dep but forget to update this list, that application won't be part of the release. That's exactly the reason for the recent bug, setting
applications: []was overriding inference.