Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show custom page after form saved #256

Open
paszin opened this issue Apr 29, 2022 · 1 comment
Open

show custom page after form saved #256

paszin opened this issue Apr 29, 2022 · 1 comment

Comments

@paszin
Copy link

paszin commented Apr 29, 2022

I use IoTWebConf to provide a customized onboarding experience. Therefore I rely on HTMLFormatProvider. I noticed that HTMLFormatProvider provides a function getFormSaved() (https://github.com/prampec/IotWebConf/blob/master/src/IotWebConf.h#L93) but this function is never called.

I made some modifications to use this function. Git Diff: paszin@b01f13c

I removed the cases of an empty AP password, empty wifi password, and the check whether the state is "notConfigured".
Would it be better to provide custom messages for each scenario? (I don't have to cover these cases in my scenarios.)

I would submit a PR after clarifying the open questions.

@mcsarge
Copy link

mcsarge commented Jul 14, 2023

I would like to + up this issue. In the code, getFormSaved() is never used, so overriding it does nothing. I would like to add another link to go to my custom page after the configuration is saved and to do this I assume that I should overide this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants