Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Prettier on commits and builds. #36

Closed
praveenscience opened this issue Feb 24, 2021 · 11 comments · Fixed by #103 · May be fixed by #41
Closed

Enforce Prettier on commits and builds. #36

praveenscience opened this issue Feb 24, 2021 · 11 comments · Fixed by #103 · May be fixed by #41

Comments

@praveenscience
Copy link
Owner

I have got this prettier options configured in VS Code. We need a way to ensure that this is there in the build times. If it's not used, including the spaces, etc., the build should fail.

{
  "arrowParens": "avoid",
  "bracketSpacing": true,
  "endOfLine": "lf",
  "htmlWhitespaceSensitivity": "css",
  "insertPragma": false,
  "jsxBracketSameLine": false,
  "jsxSingleQuote": false,
  "printWidth": 80,
  "proseWrap": "preserve",
  "quoteProps": "as-needed",
  "requirePragma": false,
  "semi": true,
  "singleQuote": false,
  "tabWidth": 2,
  "trailingComma": "none",
  "useTabs": false,
  "vueIndentScriptAndStyle": false,
  "filepath": "Untitled-1",
  "parser": "babel"
}

This issue is up for grabs for both DWoC and SWoC.

@sonaliBedade
Copy link

I am a participant of SWoC and I will like to work on this issue. I use both VS Code and Prettier extension and I am familiar with it. Please assign this issue to me so that I can start working on it.

@Sloth-Panda
Copy link
Contributor

@praveenscience sir, can you explain a bit how can we do the same?

@praveenscience
Copy link
Owner Author

@Sloth-Panda Something like this: https://gist.github.com/jareware/7179093

@praveenscience
Copy link
Owner Author

@dollyjain51099
Copy link

I would like to work on this issue, @praveenscience kindly assign it to me!

@praveenscience
Copy link
Owner Author

Hey @dollyjain51099, sure... You can also discuss with @sonaliBedade, as you both know each other! 😅

@sahildotexe
Copy link

Hey !! I 'm a participant of GSSOC'21, can you assign this issue to me?

@praveenscience
Copy link
Owner Author

@sahildotexe It's already being done by @dollyjain51099 and @sonaliBedade... Check if there are issues that are not claimed. Also check with them, they're struggling on bringing this to CI CD.

@ampsteric
Copy link
Collaborator

@praveenscience should this issue be closed as you mentioned that we are planning to use something like husky.

@praveenscience
Copy link
Owner Author

@ampsteric This is totally different. This is for the CI CD Pipeline.

@ampsteric
Copy link
Collaborator

Ohh okay , actually I saw your comment #41 (review) and thought of asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment