Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change health(readiness) checks for Controller and SegmentStore #357

Closed
pbelgundi opened this issue Apr 6, 2020 · 1 comment · Fixed by #569
Closed

Change health(readiness) checks for Controller and SegmentStore #357

pbelgundi opened this issue Apr 6, 2020 · 1 comment · Fixed by #569
Assignees
@SrishT
Labels
kind/enhancement Enhancement of an existing feature pravega 0.10.0
Milestone
Pravega Operator ...

Comments

@pbelgundi
Copy link
Contributor

Description

Current readiness checks for Controller and SegmentStore are only placeholders as the same simple port check is used for Liveness and Readiness Probes.
Readiness Probes need to be more application specific checks thaat enable us to determine if a server is capable of serving more requests or not.

Importance

should-have

Location

https://github.com/pravega/pravega-operator/blob/master/pkg/controller/pravega/pravega_controller.go#L100
https://github.com/pravega/pravega-operator/blob/master/pkg/controller/pravega/pravega_segmentstore.go#L126

Suggestions for an improvement

Depends on pravega/pravega#1665
@pbelgundi pbelgundi mentioned this issue Apr 6, 2020
Closed
2 tasks
@pbelgundi pbelgundi added priority/P1 Recoverable error, functionality/performance impaired but not lost, no permanent damage Pravega 0.8.0 Fix by pravega 0.8.0 kind/enhancement Enhancement of an existing feature priority/P2 Slight inconvenience or annoyance to applications, system continues to function status/blocked Issue or PR is blocked on another item; add reference in a comment and removed Pravega 0.8.0 Fix by pravega 0.8.0 priority/P1 Recoverable error, functionality/performance impaired but not lost, no permanent damage labels May 5, 2020
@pbelgundi
Copy link
Contributor Author

This is blocked till probes are implemented on Pravega side

@Prabhaker24 Prabhaker24 mentioned this issue Sep 10, 2020
Merged
@medvedevigorek medvedevigorek added this to the Pravega Operator 0.5.5 milestone Jul 13, 2021
@SrishT SrishT self-assigned this Jul 30, 2021
@SrishT SrishT added pravega 0.10.0 and removed status/blocked Issue or PR is blocked on another item; add reference in a comment priority/P2 Slight inconvenience or annoyance to applications, system continues to function labels Jul 30, 2021
@SrishT SrishT mentioned this issue Aug 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SrishT SrishT

Labels
kind/enhancement Enhancement of an existing feature pravega 0.10.0
Projects
None yet
Milestone
Pravega Operator 0.5.5
Development

Successfully merging a pull request may close this issue.

Issue 357: Integrating health checks pravega/pravega-operator
3 participants
@SrishT @pbelgundi @medvedevigorek