Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM options should not be hardcoded within the operator #537

Closed
SrishT opened this issue May 7, 2021 · 0 comments · Fixed by #546
Closed

JVM options should not be hardcoded within the operator #537

SrishT opened this issue May 7, 2021 · 0 comments · Fixed by #546
Assignees

Comments

@SrishT
Copy link
Contributor

SrishT commented May 7, 2021

Description

Currently many JVM options are all hardcoded within the operator, which does not allow users to remove or modify the options added by the operator by default, even if they wish to do so.

Importance

must have

Location

pkg/controller/pravega/pravega_controller.go
pkg/controller/pravega/pravega_segmentstore.go

Suggestions for an improvement

The recommended JVM options along with their default values should be specified within the values.yaml file instead, so that the user can easily modify them if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant