Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to launch Controller's container in privileged mode #544

Closed
AndreyKoltsov1997 opened this issue May 11, 2021 · 0 comments · Fixed by #545
Closed

Add ability to launch Controller's container in privileged mode #544

AndreyKoltsov1997 opened this issue May 11, 2021 · 0 comments · Fixed by #545

Comments

@AndreyKoltsov1997
Copy link
Contributor

Description

Behavior of Java applications (for example: Pravega Controller) could be analysed using profilers. They use tracers to measure a particular statistics. In case of running within Docker container environment, tracing isn't enabled by default.
Currently, unlike Segment Store Service, Pravega Controller's container couldn't be launched in "privileged mode" which makes it harder to profile the application.

Importance

nice-to-have

Location

pkg/controller/pravega/pravega_controller.go

Suggestions for an improvement

Enabling tracers could be accomplished via (1) manual specification of flags (for example: docker run .. -cap-add=SYS_PTRACE ...) or (2) running container in privileged mode.
Approach n. 2 would be sufficient in case of running application within Kubernetes environment. I propose to add the ability to run Controller container in "privileged" mode via testmode.enabled flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant