Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customized config to skip finalizers. #582

Closed
realAaronWu opened this issue Oct 13, 2021 · 1 comment
Closed

Add customized config to skip finalizers. #582

realAaronWu opened this issue Oct 13, 2021 · 1 comment

Comments

@realAaronWu
Copy link
Contributor

Description

Pravega cluster has mandatory finalizers in order to clean up znodes before deleting the pods. This should be fine if we always delete pravegacluster pods before deleting the operators. This can be done by injecting a helm pre-delete hook. But on VS7 env, they forbid calling helm hooks, and VS terminates the namespace which kills all pods/secrets/configmaps at once without ordering, so deadlock can happen if operators are killed first before the pravegacluster pods. Add this config flag to skip adding finalizers to pravegacluster to avoid this situation.

Importance

should-have

Location

reconcileFinalizers logic

Suggestions for an improvement

Add disableFinalizer config

@anishakj
Copy link
Contributor

Fixed by PR #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants