Specify encoding in open() call

Author: mxr

pre_commit_hooks/check_toml.py

@@ -13,7 +13,7 @@ def main(argv: Optional[Sequence[str]] = None) -> int:
     retval = 0
     for filename in args.filenames:
         try:
-            with open(filename) as f:
+            with open(filename, encoding='UTF-8') as f:
                 toml.load(f)
         except toml.TomlDecodeError as exc:
             print(f'{filename}: {exc}')

tests/check_toml_test.py

@@ -1,7 +1,7 @@
 from pre_commit_hooks.check_toml import main
 
 
-def test_toml_good(tmpdir):
+def test_toml_bad(tmpdir):
     filename = tmpdir.join('f')
     filename.write("""
 key = # INVALID
@@ -12,7 +12,7 @@ def test_toml_good(tmpdir):
     assert ret == 1
 
 
-def test_toml_bad(tmpdir):
+def test_toml_good(tmpdir):
     filename = tmpdir.join('f')
     filename.write(
         """
@@ -27,3 +27,10 @@ def test_toml_bad(tmpdir):
     )
     ret = main((filename.strpath,))
     assert ret == 0
+
+
+def test_toml_good_non_ascii(tmpdir):
+    filename = tmpdir.join('f')
+    filename.write_binary('letter = "\N{SNOWMAN}"'.encode())
+    ret = main((filename.strpath,))
+    assert ret == 0