Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass-loader 8 incompatiblity #880

Closed
LeviSchuck opened this issue Aug 31, 2019 · 8 comments
Closed

sass-loader 8 incompatiblity #880

LeviSchuck opened this issue Aug 31, 2019 · 8 comments

Comments

@LeviSchuck
Copy link

Do you want to request a feature or report a bug? Bug

What is the current behaviour?
Installing sass-loader results in the latest version (8.0.0) from NPM.
then running npm run start which runs preact cli tools then fails with the following error

✖ ERROR ./node_modules/preact-cli/lib/lib/webpack/proxy-loader.js??ref--2-0!./src/components/formInput/style.scss
Module build failed: ValidationError: Invalid options object. Sass Loader has been initialised using an options object that does not match the API schema.
 - options has an unknown property 'includePaths'. These properties are valid:
   object { implementation?, sassOptions?, prependData?, sourceMap?, webpackImporter? }    at validate (/mnt./src/routes/category/index.js
 @ ./src/routes/category/index.js
 @ ./src/components/app.js
 @ ./src/index.js
 @ ./node_modules/preact-cli/lib/lib/entry.js
 @ multi ./node_modules/preact-cli/lib/lib/entry webpack-dev-server/client webpack/hot/dev-server

Note this hit vue at the same time vuejs/vue-cli#4513

If the current behaviour is a bug, please provide the steps to reproduce.
Create a new preact project, the demo with a header is fine.
npm install sass-loader@8.0.0 node-sass
Rename the existing css file to a .scss file in one of the components.
npm run start

What is the expected behaviour?
Runs as usual, it works with sass-loader@7.3.1 but not 8.0.0

If this is a feature request, what is motivation or use case for changing the behaviour?
sass-loader seems to be officially listed in the documentation, maintaining support would be pleasant.

Please mention other relevant information.

Please paste the results of preact info here.

> preact info

         ▄▄ 
     ▄▄▓▓▓▓▓▓▄▄
  ▄█▀▀█▓▓▓▓▓▓▓▀▀█▄▄
▐▓▌▐▓▓▓▒▄ ▀▄▄▓▓▓▌▐▓▌
▐▓▓▄▀▓▀ ▄▓▓▄▄▀▓▓ ▓▓▌ 
▐▓▓▓▌ ▒▓▌  ▐▓▓  ▓▓▓▌ preact-cli 2.2.1
▐▓▓ ▒▓▄▄▀▓▓▀ ▄▓▓ ▓▓▌
▐▓▌▐▓▓▓▀▀▄▄▀▀▓▓▓▌▐▓▌
  ▀█▄▄▒▓▓▓▓▓▓▒▄▄▒▀
      ▀▓▓▓▓▓▓▀▀
         ▀▀
For help with a specific command, enter:
  preact help [command]

  create [template] [dest]  Create a new application.
  build [src] [dest]        Create a production build in build/
  watch [src]               Start a development live-reload server.
  serve [dir]               Start an HTTP2 static fileserver.
  list                      List all official templates

Options:
  -h, --help  Show help                                                [boolean]

Unknown argument: info

Is this an outdated command line option or issue template?

@peabnuts123
Copy link

Just commenting to confirm this behaviour in my project too. I'm not sure what change needs to be made here, however.

@lsahil
Copy link

lsahil commented Sep 13, 2019

+1 Downgrading to sass-loader@7.3.1 works.

@peterbe
Copy link

peterbe commented Sep 26, 2019

yarn add sass-loader@7.3.1 and now it starts.

@jliebrand
Copy link

Friendly ping - is anyone looking at this?

@rajivkr
Copy link

rajivkr commented Apr 22, 2020

Any update wrt this?

@zgoda
Copy link
Contributor

zgoda commented Feb 7, 2021

Now because of Webpack 4 it's incompatible with sass-loader 11.

@kentr
Copy link
Contributor

kentr commented Jan 13, 2022

It's working for me with sass-loader@10.2.0, per the README.

@rschristian
Copy link
Member

Closing, we've supported sass-loader v10+ for a while now and it's the best we can do on Webpack v4.

@rschristian rschristian closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants