Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tabIndex not getting reset in IE11 #3064

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Fix tabIndex not getting reset in IE11 #3064

merged 1 commit into from
Mar 14, 2021

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Mar 14, 2021 •
edited
Loading

Follow up to #3060. Verified via browerstack.

@github-actions
Copy link

github-actions bot commented Mar 14, 2021 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -0% - +3% (-0.49ms - +5.84ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +2% (-2.07ms - +0.84ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +3% (-22.12ms - +50.54ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -5% - +2% (-1.61ms - +0.67ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +2% (-1.57ms - +2.84ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -7% - +4% (-2.65ms - +1.56ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +4% (-0.16ms - +0.14ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-0.05ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master195.93ms - 200.00ms-unsure 🔍
-3% - +0%
-5.84ms - +0.49ms
preact-local198.21ms - 203.06msunsure 🔍
-0% - +3%
-0.49ms - +5.84ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.57ms - 3.58ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.57ms - 3.58msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master73.39ms - 75.30ms-unsure 🔍
-1% - +2%
-0.81ms - +1.58ms
preact-local73.25ms - 74.67msunsure 🔍
-2% - +1%
-1.58ms - +0.81ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master112.95ms - 114.66ms-faster ✔
0% - 3%
0.13ms - 3.48ms
preact-local114.17ms - 117.06msslower ❌
0% - 3%
0.13ms - 3.48ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master124.99ms - 131.20ms-unsure 🔍
-5% - +1%
-7.14ms - +0.75ms
preact-local128.86ms - 133.73msunsure 🔍
-1% - +6%
-0.75ms - +7.14ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master77.70ms - 82.09ms-unsure 🔍
-2% - +6%
-1.23ms - +4.52ms
preact-local76.40ms - 80.11msunsure 🔍
-6% - +1%
-4.52ms - +1.23ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master132.72ms - 141.45ms-unsure 🔍
-0% - +10%
+0.02ms - +12.62ms
preact-local126.22ms - 135.31msfaster ✔
0% - 9%
0.02ms - 12.62ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master78.47ms - 81.00ms-unsure 🔍
-4% - +1%
-2.84ms - +0.83ms
preact-local79.41ms - 82.08msunsure 🔍
-1% - +4%
-0.83ms - +2.84ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master37.62ms - 39.87ms-unsure 🔍
-2% - +5%
-0.84ms - +2.07ms
preact-local37.21ms - 39.05msunsure 🔍
-5% - +2%
-2.07ms - +0.84ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.65ms - 3.66ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.65ms - 3.66msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1897.36ms - 1944.50ms-unsure 🔍
-3% - +1%
-50.54ms - +22.12ms
preact-local1907.49ms - 1962.79msunsure 🔍
-1% - +3%
-22.12ms - +50.54ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.97ms - 25.97ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local25.97ms - 25.97msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.23ms - 32.91ms-unsure 🔍
-2% - +5%
-0.67ms - +1.61ms
preact-local30.82ms - 32.36msunsure 🔍
-5% - +2%
-1.61ms - +0.67ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.58ms - 1.58ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.58ms - 1.58msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master150.99ms - 154.23ms-unsure 🔍
-2% - +1%
-2.84ms - +1.57ms
preact-local151.75ms - 154.74msunsure 🔍
-1% - +2%
-1.57ms - +2.84ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.18ms - 6.23ms-unsure 🔍
-0% - +1%
-0.01ms - +0.05ms
preact-local6.17ms - 6.20msunsure 🔍
-1% - +0%
-0.05ms - +0.01ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master38.10ms - 41.07ms-unsure 🔍
-4% - +7%
-1.56ms - +2.65ms
preact-local37.55ms - 40.53msunsure 🔍
-7% - +4%
-2.65ms - +1.56ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.83ms - 4.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.83ms - 4.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.47ms - 3.67ms-unsure 🔍
-4% - +4%
-0.14ms - +0.16ms
preact-local3.45ms - 3.68msunsure 🔍
-4% - +4%
-0.16ms - +0.14ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.98ms - 0.98ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local0.98ms - 0.98msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Mar 14, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 99.445% when pulling 04b06e8 on ie11-tabindex into cd8d658 on master.

@github-actions
Copy link

Size Change: +28 B (0%)

Total Size: 42.3 kB

Filename Size Change
dist/preact.js 3.98 kB +9 B (0%)
dist/preact.min.js 4.02 kB +6 B (0%)
dist/preact.module.js 4.01 kB +6 B (0%)
dist/preact.umd.js 4.06 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.49 kB 0 B
compat/dist/compat.module.js 3.5 kB 0 B
compat/dist/compat.umd.js 3.54 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister mentioned this pull request Mar 14, 2021
Merged
developit
developit reviewed Mar 14, 2021
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's just make sure to remove this in 11.

@marvinhagemeister marvinhagemeister merged commit f053897 into master Mar 14, 2021
@marvinhagemeister marvinhagemeister deleted the ie11-tabindex branch March 14, 2021 20:36
This was referenced Mar 15, 2021
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Open
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinhagemeister @coveralls @developit