Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type for Element changed to ElementType: intended? #3679

Closed
shalomvolchok opened this issue Aug 18, 2022 · 8 comments · Fixed by #3680
Closed

Type for Element changed to ElementType: intended? #3679

shalomvolchok opened this issue Aug 18, 2022 · 8 comments · Fixed by #3680
Labels
needs-more-info The issue doesn't contain enough information to be able to help types

Comments

@shalomvolchok
Copy link

Before we update our types, just checking if it was intentional to remove the Element type and replace it with ElementType? Getting a TS error with 10.10.4 for h.JSX.Element

7d54883#diff-814abe9ce1d0e89a7fa1ef941142487296d1423ffad605dc1188b544056c2bcfL29

@JoviDeCroock
Copy link
Member

What error are you getting? I can double check 😅

@shalomvolchok
Copy link
Author

Namespace JSXInternal has no exported member Element

@marvinhagemeister
Copy link
Member

Ohh this is a good catch! Yeah we should keep JSX.Element. I missed that in my review.

@JoviDeCroock
Copy link
Member

On what code? Are you referencing JsX.Element yourself, with more information I can check 😅

@JoviDeCroock JoviDeCroock added needs-more-info The issue doesn't contain enough information to be able to help types labels Aug 18, 2022
@birtles
Copy link

birtles commented Aug 19, 2022

I also have code importing React as import * as React from 'preact/compat'; and referencing React.JSX.Element which is broken by 10.10.4.

@nurav97
Copy link

nurav97 commented Aug 19, 2022

This breaking the @fullcalendar package

@JoviDeCroock
Copy link
Member

Sorry about that I jumped into our tests and figured out why this doesn't show up as an error for us, we have a local override to do namespace testing. Will fix

@JoviDeCroock
Copy link
Member

Sorry about the inconvenience, published as 10.10.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info The issue doesn't contain enough information to be able to help types
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants