PictureInPictureEvent error

[rpendyala2]

Hi There,

during npm run build phase I am getting the below error. not sure of the change #4020
node_modules/preact/src/jsx.d.ts:1078:3 - error TS2304: Cannot find name 'PictureInPictureEvent'.

Error: node_modules/preact/src/jsx.d.ts:1124:3 - error TS2344: Type 'TargetedPictureInPictureEvent' does not satisfy the constraint 'TargetedEvent<EventTarget, Event>'.
11:34:07 Type 'TargetedPictureInPictureEvent' is missing the following properties from type 'Omit<Event, "currentTarget">': type, target, bubbles, cancelBubble, and 17 more.
11:34:07
11:34:07 1124 TargetedPictureInPictureEvent
11:34:07 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

can some one give hint to dig into. it was fine till last Friday.

[rschristian]

You need to use TS 4.9+ w/ Preact v10.15.0, which was released yesterday. You can upgrade your TS version or downgrade Preact.

CC @JoviDeCroock, I was a bit concerned about this. It's not the biggest issue, but anecdotally, TS tends to be one of those deps that are seldomly bumped. Relying on such a new version may be a tad problematic.

[rpendyala2]

Ryan, Thanks you for quick response

[JoviDeCroock]

You make a good point. My thinking was that the version was already quite old, however we could look into providing docs on how to extend the jsx types instead if needed 😅

[rschristian]

Yeah, and that's totally reasonable. Maybe something we want to consider for the future though, as there was also that FullCalendar Angular debacle a few months back (though that is more to blame with Angular being stuck on a really old version of TS and FullCalendar not pinning their deps, but I digress).

Anyways, I think we can close this out for now.