-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for prop:
& attr:
directives
#4419
base: main
Are you sure you want to change the base?
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
Size Change: +255 B (+0.41%) Total Size: 62.2 kB
ℹ️ View Unchanged
|
Co-authored-by: Marvin Hagemeister <hello@marvinh.dev>
3f92ec5
to
798052a
Compare
798052a
to
17fee02
Compare
I'll mark this as "ready", though I'm happy to still discuss whether we even want to do this and how it should interact with other things like RTS. IMO, it is a nice bit of power to give users though it is a bit of a deviation and might confuse some. Edit: What in the world is up with Coveralls |
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
806e605
to
8b52a19
Compare
@rschristian I like this direction, but I would love to avoid using namespaces for the prefixes. I believe vue uses something like Interestingly, JSX does allow for two suffixes: <div prop$="foo" />;
<div attr-="bar" />; The other tidbit I wanted to add to this discussion is that we do technically already have a "force to use attribute" syntax, which is to uppercase the name ( |
I'm fully aware, but it's a hard thing to push users toward; as stable as it is, it's an obvious hack that most raise an eyebrow at when it's suggested. There's a few threads recently in particular w/ users uneasy after I've suggested using capitalization to get around it, hence, this PR. It's a shame directives require some opt-in, I don't love how unclear |
First-pass impl of #4416