Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min and max type definition for MeterHTMLAttributes and ProgressHTMLAttributes are missing number #4597

Closed
devlux opened this issue Dec 7, 2024 · 0 comments · Fixed by #4598

Comments

@devlux
Copy link
Contributor

devlux commented Dec 7, 2024

The type definitions for MeterHTMLAttributes and ProgressHTMLAttributes were missed when fixing the min and max attributes in #4568.

src/components/Progress.tsx:59:48 - error TS2322: Type 'number' is not assignable to type 'Signalish<string | undefined>'.

59         <progress className={classes.progress} max={maxValue}></progress>
                                                  ~~~

  ../node_modules/.pnpm/preact@10.25.1/node_modules/preact/src/jsx.d.ts:1968:3
    1968   max?: Signalish<string | undefined>;
           ~~~
    The expected type comes from property 'max' which is declared here on type 'ProgressHTMLAttributes<HTMLProgressElement>'
@devlux devlux changed the title min and max type definition for MeterHTMLAttributes and ProgressHTMLAttributes are mising number min and max type definition for MeterHTMLAttributes and ProgressHTMLAttributes are missing number Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant