Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and improve bid timeout logic #10349

Closed
dgirardi opened this issue Aug 10, 2023 · 0 comments · Fixed by #10379
Closed

Review and improve bid timeout logic #10349

dgirardi opened this issue Aug 10, 2023 · 0 comments · Fixed by #10379
Assignees

Comments

@dgirardi
Copy link
Collaborator

Type of issue

Bug

Description

See #10320 (comment) for details - breaking this out into its own issue:

There are several problems with the timeout logic:

  • the 2nd mechanism (using timeToRespond) appears to be entirely redundant. I suspect it's a relic.
  • the 1st mechanism does not look at timeoutBuffer, which is different from what we say in the docs.
  • a bid request can be considered "late" when it isn't, if it's routed to Prebid Server and there's no client side adapter for it.
@dgirardi dgirardi changed the title Review and improve timeout logic Review and improve bid timeout logic Aug 10, 2023
@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Aug 14, 2023
@patmmccann patmmccann moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table Sep 6, 2023
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant