Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geolocationRtdProvider: lastfix does not match OpenRTB definition #10373

Closed
lambdarho opened this issue Aug 18, 2023 · 1 comment · Fixed by #10383
Closed

geolocationRtdProvider: lastfix does not match OpenRTB definition #10373

lambdarho opened this issue Aug 18, 2023 · 1 comment · Fixed by #10383
Labels

Comments

@lambdarho
Copy link
Contributor

Type of issue

bug

Description

Incorrect information passed in the BidRequest coming from geolocationRtdProvider

The geolocationRtdProvider fetches geo information from the browser and applies lat / lon / lastfix / type to ortb2Fragments.global.device.geo

The problem is that a timestamp is passed to BidRequest.device.geo.lastfix, but that does not match the OpenRTB definition.

The BidRequest.device.geo.lastfix field should be:

Number of seconds since this geolocation fix was established.
Note that devices may cache location data across multiple
fetches. Ideally, this value should be from the time the actual
fix was taken.

Steps to reproduce

Enable the geolocationRtdProvider module, let the browser access navigator.geolocation.getCurrentPosition and look at the value passed in under ortb2Fragments.global.device.geo.lastfix

Test page

Expected results

Calculate the number of seconds from when the geo information was taken and BidRequest was sent.

Actual results

The module currently sends a timestamp so the value is interpreted incorrectly.

Platform details

Prebid.js

Other information

@patmmccann patmmccann added the bug label Aug 18, 2023
@patmmccann
Copy link
Collaborator

I'm declaring this bugfix non-breaking given the recency of the module merge. Thank you for the report. Your bugfix submission is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants