GPP Consent Module Re-Uses Errored CMP Client

[evans-sam]

Type of issue

Question, Bug

Description

The GPP Consent Module appears to re-use the errored state of the cmp client instead of look searching again. This seems to be unexpected behavior

Prebid.js/modules/consentManagementGpp.js

Lines 72 to 83 in 32ff256

	static init(mkCmp = cmpClient) {
	if (this.INST == null) {
	this.INST = this.ping(mkCmp).catch(e => {
	this.INST = null;
	throw e;
	});
	}
	return this.INST.then(([client, pingData]) => [
	client,
	client.initialized ? client.refresh() : client.init(pingData)
	]);
	}

Prebid.js/test/spec/modules/consentManagementGpp_spec.js

Lines 292 to 302 in 32ff256

	it('should not re-use errors', (done) => {
	cmpResult = Promise.reject(new Error());
	GPPClient.init(makeCmp).catch(() => {
	cmpResult = {signalStatus: 'ready'};
	return GPPClient.init(makeCmp).then(([client]) => {
	expect(client).to.exist;
	done()
	})
	})
	})
	})

Steps to reproduce

Initialize pbjs and request bids before a cmp is loaded. Try again after the cmp as loaded. The test page attempts to run an auction, then loads the stub cmp, and tries again. When debugging, the gpp module does not try to initialize a new cmp client and just throws the previous error

Test page

https://jsfiddle.net/u2dqnh8v/

Expected results

the gpp module searches for the cmp again, the way gdpr and usp seem to work

Actual results

Platform details

latest version of prebid, Chrome and Firefox

Other information