Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionable zmaticoo adapter parameters #11081

Closed
bretg opened this issue Feb 8, 2024 · 3 comments · Fixed by #11056
Closed

Questionable zmaticoo adapter parameters #11081

bretg opened this issue Feb 8, 2024 · 3 comments · Fixed by #11056

Comments

@bretg
Copy link
Collaborator

bretg commented Feb 8, 2024

Type of issue

adapter rules

Description

Looking over the documentation for the zmaticoo bid adapter, found something that escaped code review.
#10881

  1. It requires "bidId" as a parameter. This is probably wrong. bidId should be random, unless they mean something odd, but it's not even listed on their adapter docs
  2. It requires a "device" object as a parameter. Clearly not allowed. They need to be reading from the ORTB2.device object, and there's no way they should be requiring IP address. (A) we can't share that data and (B) that should be easy for them get from their endpoint.

Heads up @lxj15398019970

@patmmccann
Copy link
Collaborator

tagging as 9 to indicate reversion of the merge if this isnt solved beforehand

@lxj15398019970
Copy link
Contributor

@patmmccann i hava fixed it

@lxj15398019970
Copy link
Contributor

tagging as 9 to indicate reversion of the merge if this isnt solved beforehand

ok,i have fixed it

@patmmccann patmmccann linked a pull request Feb 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants