Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue With Rubicon adapter on Safari #122

Closed
jdelhommeau opened this issue Dec 2, 2015 · 2 comments
Closed

Issue With Rubicon adapter on Safari #122

jdelhommeau opened this issue Dec 2, 2015 · 2 comments
Assignees
Labels

Comments

@jdelhommeau
Copy link
Collaborator

It seems there is a bug in the Rubicon adaptor with safari and edge browser.

this line is not working in Safari (tested by me) and neither in edge (so I was told, I didn't test)

line 879 in prebid.js : var rubiconObj = iframeObj.contentWindow.RubiconAdServing;

the contentWindow variable is undefined in Safari. In order for it to work, we need to change the line to:

var rubiconObj = iframeObj.window.RubiconAdServing;

@ialex
Copy link
Contributor

ialex commented Dec 2, 2015

You could change that line to:

var rubiconObj = iframeObj.contentWindow.RubiconAdServing || iframeObj.window.RubiconAdServing;

That way if the first doesn't exists the second will be used

@hjeong12
Copy link
Contributor

hjeong12 commented Dec 8, 2015

fixed in #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants