Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting wrong size in bid response with Audience network adaptor #1851

Closed
TaipeidogLee opened this issue Nov 20, 2017 · 7 comments
Closed

Getting wrong size in bid response with Audience network adaptor #1851

TaipeidogLee opened this issue Nov 20, 2017 · 7 comments

Comments

@TaipeidogLee
Copy link

Type of issue

Getting wrong size in bid response with Audience network adaptor

Description

Just found if I use the latest Prebid.js(0.33) downloaded from prebid site, the size in my bid response always shows '3x0', so the DFP returns a 3x0 size creative. However in the bid asked to AN, the size is correct.
https://an.facebook.com/v2/placementbid.json?placementids[]=340593302966493_499764643716024&adformats[]=300x250&testmode=true&pageurl=&sdk[]=5.5.web

If I use the 'fullwidth' format in bid params then the size is correct.
Also if I switch the prebid.js to older version (0.25), size is also correct.

Test page

http://deanlee-test1-aws-php.us-west-2.elasticbeanstalk.com/HB_test.html?anhb_testmode=true

Expected results

showing 300x250 ad

Actual results

showing 3x0 ad

Platform details

0.33 prebid, osx, chrome

screen shot 2017-11-20 at 11 49 44 am

@bretg
Copy link
Collaborator

bretg commented Nov 20, 2017

@TaipeidogLee - did this happen in previous versions?

@lovell - any suggestions about this one?

There's another issue #1854 around the AN adapter, but this doesn't look to be related. There hasn't been a change to the adapter in some time. Perhaps there was a change on the AN API that isn't reflected in the adapter?

@TaipeidogLee
Copy link
Author

Hi @bretg , I have not checked the previous version but only checked v0.33 and v0.25, v0.25 works though. Any ways I can get other versions?
thanks.

@lovell
Copy link
Contributor

lovell commented Nov 20, 2017

Hello, I've no immediate ideas about what could be causing this - perhaps something expecting to split a string but fed an array or vice versa? Will speak with a few people at Facebook.

@TaipeidogLee
Copy link
Author

TaipeidogLee commented Nov 21, 2017

Hi, I got some help saying the code in adaptor should be modified as in image attached, since I am not using npm or yarn to install prebid on my end and I can't change it accordingly on obfuscated version so can anyone help to confirm and update this? thanks.

23675070_192166604693653_743290489555077496_o

@lovell
Copy link
Contributor

lovell commented Nov 21, 2017

@TaipeidogLee Thank you, I agree, we'll get this fixed. It was introduced in v0.32 by commit 403a991 so if you can use v0.31 you'll avoid this problem for now.

@TaipeidogLee
Copy link
Author

Hi @lovell , thanks for prompt response.
Is there any way for user to choose different version or prebid on prebid site? not every developer are using npm or yarn.

@lovell
Copy link
Contributor

lovell commented Nov 22, 2017

PR for this at #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants