Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Currency] Request latest.json over https #1858

Closed
amelzer opened this issue Nov 21, 2017 · 6 comments
Closed

[Currency] Request latest.json over https #1858

amelzer opened this issue Nov 21, 2017 · 6 comments
Assignees

Comments

@amelzer
Copy link

amelzer commented Nov 21, 2017

Type of issue

Feature Request / Bug

Description

latest.json is currently requested over http which leads to some browsers blocking the request if the prebid bundle with currency module is used in a site being servedwith https

Steps to reproduce

  1. Build prebid bundle with currency modules
  2. Use in a site with https
  3. pbjs.setConfig({ currency: { adServerCurrency: 'EUR' } })

Expected results

Currency conversion can be set up

Actual results

screen shot 2017-11-21 at 13 36 51

Currency conversion can not be set up.

Platform details

e.g. Chrome Browser

Other information

Tied to #1843 as failing to set up currency conversion leads to prebid not working at all (no bid responses at all)

@YOzaz
Copy link

YOzaz commented Nov 21, 2017

That's more than fixing one symbol unfortunately... (I think). Whole prebid.org will have to be put on SSL.

@mkendall07
Copy link
Member

That's right. We are in the process of obtaining a cert for this. Stay tuned.

@bretg
Copy link
Collaborator

bretg commented Nov 21, 2017

This is a known issue as noted in the doc. Issue #1834 was directly tied to our being able to fix this feature. The plan is to make it happen early in January.

@bretg bretg self-assigned this Nov 21, 2017
@stale
Copy link

stale bot commented Mar 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 6, 2018
@stale stale bot closed this as completed Mar 13, 2018
@bretg bretg removed the wontfix label Mar 13, 2018
@bretg
Copy link
Collaborator

bretg commented Mar 13, 2018

Ironic that stale-bot closed this at just about the same time we were launching the feature.

Good news -- https://currency.prebid.org/latest.json is now available.

@bboigienman
Copy link

Should we use conversionRateFile parameter to use https URI instead of the http one or Prebid will guess it automatically (and from which version)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants