-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Currency] Request latest.json over https #1858
Comments
That's more than fixing one symbol unfortunately... (I think). Whole prebid.org will have to be put on SSL. |
That's right. We are in the process of obtaining a cert for this. Stay tuned. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ironic that stale-bot closed this at just about the same time we were launching the feature. Good news -- https://currency.prebid.org/latest.json is now available. |
Should we use conversionRateFile parameter to use https URI instead of the http one or Prebid will guess it automatically (and from which version)? |
Type of issue
Feature Request / Bug
Description
latest.json
is currently requested overhttp
which leads to some browsers blocking the request if the prebid bundle with currency module is used in a site being servedwithhttps
Steps to reproduce
pbjs.setConfig({ currency: { adServerCurrency: 'EUR' } })
Expected results
Currency conversion can be set up
Actual results
Currency conversion can not be set up.
Platform details
e.g. Chrome Browser
Other information
Tied to #1843 as failing to set up currency conversion leads to prebid not working at all (no bid responses at all)
The text was updated successfully, but these errors were encountered: