Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfills polluting global namespace, causing errors #1911

Closed
snapwich opened this issue Dec 2, 2017 · 3 comments
Closed

Polyfills polluting global namespace, causing errors #1911

snapwich opened this issue Dec 2, 2017 · 3 comments
Assignees
@snapwich
Labels
bug

Comments

@snapwich
Copy link
Collaborator

snapwich commented Dec 2, 2017

Type of issue

bug

Description

The core-js polyfills are exporting a global variable named core. This breaks some sites that may already be using a global variable named core on their site.

Steps to reproduce

Use a global variable named core on your site and include Prebid.js. It will be overwritten by the core-js library.
@matthewlane matthewlane added the bug label Dec 2, 2017
@mkendall07
Copy link
Member

just don't use core, problem solved. :)

@snapwich
Copy link
Collaborator Author

snapwich commented Dec 4, 2017

Unfortunately at least one of our client's proprietary frameworks is intent on that using that global. However, I'm more worried about the clients using core without realizing its in contention and creating obscure bugs.

@snapwich snapwich mentioned this issue Dec 5, 2017
Merged
2 tasks
@ghost ghost assigned snapwich Dec 5, 2017
@ghost ghost added the in progress label Dec 5, 2017
@mkendall07
Copy link
Member

This is resolved in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snapwich snapwich

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snapwich @matthewlane @mkendall07