Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override ad unit sizes in bid request #2010

Closed
mmilleruva opened this issue Jan 4, 2018 · 4 comments
Closed

Override ad unit sizes in bid request #2010

mmilleruva opened this issue Jan 4, 2018 · 4 comments

Comments

@mmilleruva
Copy link
Collaborator

mmilleruva commented Jan 4, 2018

Type of issue

Question/Feature Request

Description

Is it possible to override adunit sizes for a specific bid request in that ad unit. Looking at the example below, my adunit accepts 2 sizes. I only want the first bid request to be able to bid on 300x250 sizes.

The primary use case for this is to allow for premium inventory sizes that I would only allow certain partners to bid on. Or if we have a partner with lower quality ads, we don't let them buy the larger inventory sizes

var adUnits = [
        {
            code: 'test-ad',
            sizes: [[300, 250], [300, 600]],
            bids: [
{
                    bidder: 'onedisplay',
                    sizes: [[300,250]],
                    params: {
                        dcn: '2c9d2b50015a5aa95b70a9b0b5b10012',
                        pos: 'header'
                    }
                },
                {
                    bidder: 'onedisplay'
                    params: {
                        placement: '3611253',
                        network: '9599.1',
                        bidFloor: '0.80',
                        keyValues: {
                            test: 'key'
                        }
                    }
                }
            ]
        }
    ];
@mkendall07
Copy link
Member

@mmilleruva
I believe you can do this with labels http://prebid.org/dev-docs/publisher-api-reference.html#labels

You'd define a subset of sizes on the label and then label the bidder and it should get the subset of sizes in the request.

@bretg
Copy link
Collaborator

bretg commented Jan 21, 2018

Actually not sure that's going to work @mkendall07. Labels aren't associated with sizes -- they're just tags that can be used to conditionally include/exclude bids. The sizeConfig feature supports overriding sizes, but that would be for all bids in the AdUnit.

I think that for a single bid in the AdUnit to have a subset of sizes, the bidder adapter would need to support that. Apparently not many do. So I think this is an enhancement request to allow per-bidder override of the sizes seen by each adapter.

@GeneGenie
Copy link
Contributor

GeneGenie commented Mar 2, 2018

@bretg almost all adapters are sending all possible sizes configured on adUnit to bid request.
If your bid supports only 300x250 you wont get any other sizes in response, you just have to setup placement in onedisplay member zone.

@stale
Copy link

stale bot commented Mar 16, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 16, 2018
@stale stale bot closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants