Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hb_uuid key to => hb_cache_id #2189

Closed
mkendall07 opened this issue Feb 23, 2018 · 2 comments
Closed

Change hb_uuid key to => hb_cache_id #2189

mkendall07 opened this issue Feb 23, 2018 · 2 comments
Labels
improvement pinned won't be closed by stalebot

Comments

@mkendall07
Copy link
Member

Currently for video bids, we cache using the uuid. This key is passed as hb_uuid. Unfortunately we also are using the same key as hb_cache_id for Prebid Server. We need to unify these keys.

I propose we change the current hb_uuid key in prebid.js to match prebid server hb_cache_id
@stale
Copy link

stale bot commented Mar 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 12, 2018
@mkendall07 mkendall07 added the pinned won't be closed by stalebot label Mar 12, 2018
@stale stale bot removed the wontfix label Mar 12, 2018
@jaiminpanchal27
Copy link
Collaborator

We have added hb_cache_id with this PR #2363
We will be deprecating the usage of hb_uuid

@patmmccann patmmccann mentioned this issue May 12, 2020
Closed
@patmmccann patmmccann mentioned this issue Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement pinned won't be closed by stalebot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snapwich @mkendall07 @jaiminpanchal27 @jjredfern