Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner user syncs not called for OpenRTB endpoint in prebid server adapter #2355

Closed
haohany opened this issue Apr 4, 2018 · 3 comments
Closed
Labels

Comments

@haohany
Copy link
Contributor

haohany commented Apr 4, 2018

Type of issue

bug?

Description

Partner user sync are called when interpreting the legacy response: https://github.com/prebid/Prebid.js/blob/master/modules/prebidServerBidAdapter.js#L341-L347
However, this functionality doesn't exist in the new OpenRTB endpoint.
The sync rate of server-side partners will be hurt if publishers move to the new endpoint.

I'm happy to submit a PR if this is indeed an issue.

@dbemiller
Copy link
Contributor

dbemiller commented Apr 5, 2018

This may be because the /openrtb2/auction endpoint doesn't return the user syncs anywhere. It would need to be added there first.

But... we did discuss this, and didn't think it would hurt much (if at all) because Prebid.js should still be hitting the /cookie_sync endpoint and logging the syncs from there.

Nobody really knew why both /auction and /cookie_sync returned cookie syncs, and I didn't find any discussions about the design on github... so I assumed it was probably an accident of history and left it out of /openrtb2/auction.

I haven't heard any complaints from OpenRTB publishers yet... but if you migrate and find the sync rate to be much lower, I'd love to know about it!

@haohany
Copy link
Contributor Author

haohany commented Apr 5, 2018

@dbemiller I think you were talking about the sync between a partner and the prebid server. That part would be ok with the new endpoint as you mentioned.

The prebid user sync API recommends partners to define a registerSyncs function to drop their own pixels. But it's not called with the new endpoint. That would put the server-side partners at a disadvantage compared to the client-side counterparts.

@stale
Copy link

stale bot commented Apr 19, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 19, 2018
@stale stale bot closed this as completed Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants