-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intent to Implement: Updates to UserSync API #2386
Comments
The new design is fine, but would prefer the terms "include" and "exclude" over "white" and "black". More importantly, we need to keep the old functionality around -- breaking changes need to be avoided, IMO... 1.0 was enough. That said, we can provide a mapping between the old interface and the new pretty easily. e.g. if iframeEnabled=true, treat as if it were
Similar for if pixelEnabled=true:
|
@mkendall07, @jsnellbaker - any thoughts on backwards compatibility? |
adding @mjacobsonny as well to share his thoughts. |
I'm fine with what @bretg proposed and we can "soft" deprecate the old methods / update our examples to use the new filter options. Soft deprecations can be removed as part of the next major release (i.e. 2.x) |
@bretg when preserving the old fields (eg eg if a publisher had a setup like the following:
Should we:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Type of issue
Feature
Description
In order to offer additional features to the UserSync functionality, we plan to implement some changes to the API. This includes adding and removing existing fields which make break current setups. Below is a pair of lists of the new and deprecated fields, with an explanation of the functional changes further below.
This will require some adapters to update their
getUserSyncs
code in case they were referring to deprecated fields.API changes
New fields
filterSettings: {config}
Deprecated fields
iframeEnabled: bool
pixelEnabled: bool
enabledBidders: []
All other API fields that exist today and not listed here would remain and retain their existing functionality.
Functional changes
Currently the only filtering field available is the
enabledBidders
field. This field takes a list of bidders and acts as a white-list, allowing only those listed bidders to drop their iframe and image pixels. Additionally the iframe pixels are only dropped if they've also included theiframeEnabled
field in the config and set it totrue
.The proposed changes will offer the following:
filterSettings
field will accept an object config that allows the publisher to set a white-list or black-list filter against a list of bidders.iframeEnabled
)The
filterSettings
config would look like the following:The
bidders
field would either accept a list of strings of the bidders or a'*'
string to indicate all bidders.The
filter
field is an enum that accepts eitherwhite
orblack
to indicate which type of filtering logic should be applied for the tracking type.As mentioned earlier, not including one of the
iframe
orimage
fields means today's default logic would be used. In case of noimage
object, all bidders are permitted to drop their image pixels. In case of noiframe
object, no bidders are permitted to drop their iframe pixels.If a publisher wanted to enable all bidders drop their iframe pixels, they'd need to configure the
filterSettings
field with an iframe object using the'*'
andwhite
filter option.The text was updated successfully, but these errors were encountered: