Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsentManagement module problem with multiple calls to requestBids #2586

Closed
rale opened this issue May 21, 2018 · 3 comments
Closed

ConsentManagement module problem with multiple calls to requestBids #2586

rale opened this issue May 21, 2018 · 3 comments
Assignees
Labels

Comments

@rale
Copy link

rale commented May 21, 2018

Type of issue

Bug

Description

If more than one call to requestBids is made while the GDPR ConsentManagement module is enabled, all but the last call are dropped.

Steps to reproduce

  • Enable consentManagement module
  • Create two separate ad units, calling requestBids separately for each one, before consent is loaded

Expected results

Both auctions should run.

Actual results

Only the last auction is run.

Platform details

Prebid 1.11.0

Other information

I took a look at consentManagement.js, and it appears as though requestBidsHook is overwriting the context each time requestBids is called.

@mkendall07
Copy link
Member

looks like you are correct. Thanks for the bug report. @jsnellbaker please address. Thanks

@jsnellbaker
Copy link
Collaborator

@rale Thanks for reporting this bug. I have put together a fix that addresses this problem (#2612). We'll try to get it included soon.

@mkendall07
Copy link
Member

this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants