Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling Prebid Server Bidders who aren't in Prebid.js #2659

Closed
dbemiller opened this issue May 31, 2018 · 7 comments
Closed

Calling Prebid Server Bidders who aren't in Prebid.js #2659

dbemiller opened this issue May 31, 2018 · 7 comments
Assignees

Comments

@dbemiller
Copy link
Contributor

Type of issue

question, maybe feature request

Description

Oath just submitted a Bidder to Prebid Server in prebid/prebid-server#520... but I don't see them in Prebid.js anywhere.

Question is: If a publisher uses Oath as a bidder, uses PBS bidder params in their ad units, and lists oath in their s2sconfig, will Prebid.js include them properly in the PBS request?

If not: could we make it happen?

@mkendall07
Copy link
Member

I'm not sure but my guess would be no.
The good news is Oath is the new company formed for AOL so I think they do a have an adapter, https://github.com/prebid/Prebid.js/blob/master/modules/aolBidAdapter.js the names just don't match.

@dbemiller
Copy link
Contributor Author

I pinged them on their PR and linked them here... will see what they say.

@kizzard
Copy link
Contributor

kizzard commented May 31, 2018

The Oath/Brightroll PBS adapter is not the same as the AOL adapter in PB - they hit totally different systems. You are correct that there is no matching adapter in PB.

@mkendall07
Copy link
Member

@kizzard
Thanks for the clarification. I think this might work ok even if there isn't a client side adapter. Will investigate a bit.

@mercuryyy
Copy link
Contributor

How would you request a build without a client side adapter?

@jsnellbaker
Copy link
Collaborator

@mercuryyy I believe you would just choose the Prebid Server adapter to make the build. You would also include the DFP Video module if you were using DFP for instream video delivery.

I've been investigating into the changes required to allow a Prebid Server bidder to make a request through Prebid.js without setting up a corresponding adapter file in Prebid.js. I believe I have it working for both banner/video delivery and will plan to put up a PR soon.

@dbemiller
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants