getAdserverTargeting() does returns empty targeting for adUnit slots

[Saigredan]

Type of issue

Bug

Description

Since 1.15.0 getAdserverTargeting() or related methods are not returning targeting for adUnit slots

Steps to reproduce

Anywhere after auctionEnd event fire getAdserverTargeting() method.

Expected results

Targeting for specified adUnit slots

Actual results

Empty Taregeting for adUnit slots

Platform details

Prebid 1.15.0

Other information

This change from latest release is probably the source of issue:
c82572e

[Saigredan]

Anyone else encounters same problem?

[YOzaz]

@Saigredan just on a matter of interest - where do you use getAdserverTargeting() method call?

[Saigredan]

@YOzaz We're using it for some internal communication methods. Usually after auction is finished.

[YOzaz]

@Saigredan the reason behind is here: #2676 and here: #2685.
I'm not 100% sure how this fix "fixes" auction concurrency problem, but @jaiminpanchal27 may have more comments on it?

[Saigredan]

@YOzaz well, after rollbacking c82572e commit, all started to work just fine (except thing we noted in other Issue #2752)

I will take a look at issues you attached

[YOzaz]

@Saigredan this commit / bugfix solved concurrent auctions issue, when multiple requests for bids were done at the same time - which is actual in our case e.g., as we're lazy-loading ads.

[Saigredan]

@YOzaz I see. I will take a deeper look

[jaiminpanchal27]

@YOzaz @Saigredan I added c82572e commit, because getAdserverTargeting() was including all bids received to get targeting.

What it should be doing is select bid from bid pool, and apply following filters

• should be unused bid
• should not be expired

[harpere]

@Saigredan can we close this?

[Saigredan]

@harpere yes, please :)