Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 1.27.0 increased 30% in filesize #3169

Closed
benjaminclot opened this issue Oct 10, 2018 · 2 comments
Closed

Prebid 1.27.0 increased 30% in filesize #3169

benjaminclot opened this issue Oct 10, 2018 · 2 comments

Comments

@benjaminclot
Copy link
Contributor

benjaminclot commented Oct 10, 2018

Type of issue

Question

Description

The Criteo adapter just increased our Prebid's compiled file size by 30% (from 150KB to 210KB)... 👎

Steps to reproduce

Use the Criteo adapter

Platform details

Prebid.js 1.27.0

@mkendall07
Copy link
Member

@benjaminclot
I required Criteo to add the signing to the verify the payload they eval is safe (to prevent executing unknown payloads.)

Unfortunately, due to Criteo's requirement to have the eval run synchronously, they imported external libraries to do the signing verification. The libraries themselves are only included when you include Criteo as a bidder.

@akira28
Copy link

akira28 commented Jan 31, 2019

Maybe it has already been asked, but why Criteo is allowed to use eval? Is the only adapter using it, and this causes the import of js-encrypt (more than 35kb gzipped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants