Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resetPresetTargeting not available for setTargetingForAst #3396

Closed
markuspovelainen opened this issue Dec 19, 2018 · 4 comments
Closed

resetPresetTargeting not available for setTargetingForAst #3396

markuspovelainen opened this issue Dec 19, 2018 · 4 comments
Assignees
Labels

Comments

@markuspovelainen
Copy link

Seems that the resetPresetTargeting is missing from setTargetingForAst. https://github.com/prebid/Prebid.js/blob/master/src/prebid.js#L211-L222

This is a problem on SPA sites using Appnexus ad server as the prebid library sets the old key-values for ad placements when you move to the next page.

@stale
Copy link

stale bot commented Jan 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 2, 2019
@mkendall07 mkendall07 added bug and removed stale labels Jan 3, 2019
@mkendall07
Copy link
Member

this is resolved with #3448

@markuspovelainen
Copy link
Author

I'm sorry to say but it doesn't clear the prebid globals for targeting. Meaning if you get a bid from page 1 and do SPA-style page change to page 2 which you don't get bid prebid still has the previous values in globals which will be set as a keywords to Appnexus on page 2. Seems that for for gpt global clean up is defined here: https://github.com/prebid/Prebid.js/blob/master/src/prebid.js#L190
ping @mkendall07

@deekshithraop deekshithraop reopened this Jan 22, 2019
@deekshithraop
Copy link
Contributor

Hey @markuspovelainen would you be able to setup a test page where we can see this actually happening please.

@deekshithraop deekshithraop self-assigned this Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants