Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RegExp of webpack config in the README is wrong #5038

Closed
pinkiebala opened this issue Mar 27, 2020 · 1 comment · Fixed by #5088
Closed

The RegExp of webpack config in the README is wrong #5038

pinkiebala opened this issue Mar 27, 2020 · 1 comment · Fixed by #5088
Assignees

Comments

@pinkiebala
Copy link

Type of issue

README typo

Description

In Usage (as a npm dependency) > With Babel 7:

new RegExp(`\\${path.sep}prebid\.js`), is trying to match /prebid.js,
but this regex will output like this: /\/prebid.js/,
the . here will match any charactor, not character . literally .

new RegExp(`\\${path.sep}prebid\\.js`),, two backslash, is the correct pattern.
This will output as /\/prebid\.js/

Expected results

/\/prebid\.js/

Actual results

/\/prebid.js/

@jsnellbaker
Copy link
Collaborator

jsnellbaker commented Apr 7, 2020

Created a PR for this issue. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants